Merged
Conversation
kuenishi
changed the base branch from
pfn-ozone-1.3.990007
to
pfn-ozone-1.3.990008
k5342
approved these changes
Aug 15, 2023
Comment on lines
+386
to
+395
| protected Optional<Response> checkIfReadonly() { | ||
| // Check if the S3Gateway is in read-only mode or not. | ||
| if (getClient().getConfiguration().getBoolean( | ||
| S3GatewayConfigKeys.OZONE_S3G_READONLY, | ||
| S3GatewayConfigKeys.OZONE_S3G_READONLY_DEFAULT)) { | ||
| return Optional.of(Response.status(HttpStatus.SC_METHOD_NOT_ALLOWED). | ||
| header("Allow", "GET,HEAD").build()); | ||
| } | ||
| return Optional.empty(); | ||
| } |
Member
There was a problem hiding this comment.
nit: I think throwing newError() here is a more uniform way.
Member
There was a problem hiding this comment.
Ah, we need to serve allowed methods because we use 405 error code here. I understand.
k5342
reviewed
Aug 15, 2023
| "dir1", null, null, null, null, null); | ||
|
|
||
| Assert.assertEquals(Status.OK.getStatusCode(), response.getStatus()); | ||
| } |
Member
There was a problem hiding this comment.
Do we need a test for initializeMultipartUpload here?
k5342
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit 1ad9c8f) Tweak tests
k5342
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit 1ad9c8f) Tweak tests
k5342
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit 1ad9c8f) Tweak tests
k5342
pushed a commit
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit 1ad9c8f) Tweak tests
k5342
pushed a commit
that referenced
this pull request
Feb 18, 2025
(cherry picked from commit 1ad9c8f) Tweak tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)